Re: [PATCH v3 1/3] dt-bindings: pinctrl: add Ambarella CV75 pinctrl
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The vendor prefix `ambarella` is used in the compatible string and custom properties, but it is not documented in `vendor-prefixes.yaml`. -- --- Patch [1]: [PATCH v3 1/3] dt-bindings: pinctrl: add Ambarella CV75 pinctrl --- commit 5b88d5c225a30fdaad8b8cfdef550c4ad783f17b Author: Long Zhao <[email protected]> dt-bindings: pinctrl: add Ambarella CV75 pinctrl Document the CV75 pin controller binding using generic function and groups properties for pinmux configuration. > diff --git a/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml > new file mode 100644 > index 0000000000000..9d65da32d3d28 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml [ ... ] > +properties: > + compatible: > + const: ambarella,cv75-pinctrl [Severity: Low] Does the ambarella vendor prefix exist in vendor-prefixes.yaml? Running make dt_binding_check will fail because this vendor prefix is not documented in the device tree bindings registry. Should this commit (or a prerequisite patch) add it to prevent validation errors? > + > + reg: > + maxItems: 1 > + description: IOMUX registers > + > + ambarella,drive-strength-syscon: [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1