Re: [PATCH v3 1/2] dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The 'ambarella' vendor prefix is newly introduced in this binding but is not documented in vendor-prefixes.yaml. -- --- Patch [1]: [PATCH v3 1/2] dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart --- commit 09140ea99754febddffd7c03dfcd93c0fffe28fb Author: Long Zhao <[email protected]> dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart Add the Ambarella CV75 compatible string to the Synopsys DW APB UART binding. > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > index 49f51b0028795..cec5c679f1a9d 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > @@ -51,6 +51,7 @@ properties: > - const: renesas,rzn1-uart > - items: > - enum: > + - ambarella,cv75-uart [Severity: Low] Has the ambarella vendor prefix added to properties:compatible been formally documented in vendor-prefixes.yaml? If this prefix is omitted from vendor-prefixes.yaml, evaluating this schema with dt-schema will encounter the undocumented ambarella prefix. This will cause make dt_binding_check to report a schema validation warning or error during the build. > - anlogic,dr1v90-uart > - brcm,bcm11351-dw-apb-uart > - brcm,bcm21664-dw-apb-uart -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1