Re: [PATCH v7 5/7] ARM: dts: microchip: sama5d27_wlsom1: use fixed-partitions for QSPI flash

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `#address-cells` and `#size-cells` properties were left behind in the `qspi1_flash: flash@0` node after moving its partition children into a `partitions` subnode.
--

--- Patch [5]: [PATCH v7 5/7] ARM: dts: microchip: sama5d27_wlsom1: use fixed-partitions for QSPI flash ---
commit 2272ae3c8afd10d0823376b2412b60934678478f
Author: Manikandan Muralidharan <[email protected]>
Subject: ARM: dts: microchip: sama5d27_wlsom1: use fixed-partitions for QSPI flash

This commit moves the QSPI flash partitions into a new partitions
subnode with the fixed-partitions compatible string. This change
aligns the device tree with the current MTD partition binding requirements.

> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> index 0417f53b3e964..062aa02a98edd 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> @@ -240,34 +240,40 @@ qspi1_flash: flash@0 {

[Severity: Low]
This is a pre-existing issue, but should the #address-cells and
#size-cells properties be removed from the qspi1_flash: flash@0 node?

Now that the partitions have been moved to the new partitions subnode,
leaving these properties in the parent flash node can cause dtc warnings
(avoid_unnecessary_addr_size).

It also violates the MTD binding schema, which deprecates them at the
flash node level when a partitions subnode is used.

>  		m25p,fast-read;
>  		status = "disabled";
>  
> -		at91bootstrap@0 {
> -			label = "at91bootstrap";
> -			reg = <0x0 0x40000>;
> -		};
> +		partitions {
> +			compatible = "fixed-partitions";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5