Re: [PATCH v2 2/3] arm64: dts: qcom: monaco-evk: Add LVDS display overlay

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing driver support for lontium,lt9211c compatible string
- [Medium] Missing driver support for boe,dv215fhm-r01 panel compatible string
--

--- Patch [2]: [PATCH v2 2/3] arm64: dts: qcom: monaco-evk: Add LVDS display overlay ---
commit 11e343dd5f10984f8afa017886ae2c19711c5c47
Author: Vishnu Saini <[email protected]>

arm64: dts: qcom: monaco-evk: Add LVDS display overlay

The commit adds a DTBO overlay for the Monaco-EVK mezzanine that supports
LVDS display output using a Lontium LT9211C bridge and a BOE DV215FHM-R01
panel.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso
> new file mode 100644
> index 0000000000000..96a53a294863b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso
[ ... ]
> +&{/} {
> +	model = "Qualcomm Technologies, Inc. Monaco EVK LVDS";
> +
> +	panel_lvds: panel-lvds {
> +		compatible = "boe,dv215fhm-r01";

[Severity: Medium]
Will this compatible string fail to bind?

The commit message claims this panel is matched against the
panel-simple-lvds-dual-ports binding, which supplies size and timing
internally, but "boe,dv215fhm-r01" appears to be missing from the
panel-simple.c driver. 

Since there is no generic fallback (like "panel-lvds") with inline timings
provided here, won't this leave the display unconfigured?

> +		power-supply = <&lcd_disp_bias>;
> +
> +		status = "okay";
[ ... ]
> +&i2c8 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&qup_i2c8_data_clk>;
> +
> +	status = "okay";
> +
> +	lt9211c_codec: lvds-bridge@2d {
> +		compatible = "lontium,lt9211c";

[Severity: Medium]
Is "lontium,lt9211c" supported by any existing driver?

It looks like this compatible string is absent from any driver's OF match
table, and there is no fallback provided (such as "lontium,lt9211"). 

Does this cause the I2C device instantiation for the bridge to fail?

> +		reg = <0x2d>;
> +		reset-gpios = <&tlmm 66 GPIO_ACTIVE_HIGH>;
> +		vccio-supply = <&vreg_l5a>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2