Re: [PATCH v2 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing driver support for compatible strings 'boe,dv215fhm-r01' and 'lontium,lt9211c'.
--

--- Patch [1]: [PATCH v2 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay ---
commit 982b78f0ee343a881d363b06b3c257a529f0e73b
Author: Vishnu Saini <[email protected]>

arm64: dts: qcom: lemans-evk: Add LVDS display overlay

This commit adds a device tree overlay for the Lemans EVK IFP mezzanine to
support LVDS display output. It wires up the Lontium LT9211C DSI-to-LVDS
bridge and a BOE dv215fhm-r01 LVDS panel.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
> new file mode 100644
> index 0000000000000..82b6eeddbb8b0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
[ ... ]
> +&{/} {
> +	model = "Qualcomm Technologies, Inc. Lemans EVK LVDS";
> +
> +	panel_lvds: panel-lvds {
> +		compatible = "boe,dv215fhm-r01";

[Severity: Medium]
Will this panel successfully probe? It looks like the compatible string
"boe,dv215fhm-r01" does not exist in the kernel tree's match tables (e.g.,
in panel-simple.c), and there is no generic fallback compatible string
provided here. 

Does the panel driver need to be updated upstream first, or should this node
include a fallback like "panel-lvds" along with explicit DT timings so the
generic driver can bind to it?

> +		power-supply = <&lcd_disp_bias>;
> +
> +		status = "okay";
[ ... ]
> +&i2c1 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&qup_i2c1_default>;
> +
> +	status = "okay";
> +
> +	lt9211c_codec: lvds-bridge@2d {
> +		compatible = "lontium,lt9211c";

[Severity: Medium]
Is the "lontium,lt9211c" compatible string currently supported by the bridge
driver? It appears the lontium bridge driver might only match against
"lontium,lt9211", which would prevent the driver core from binding to this
bridge node. 

Could this use a fallback compatible string (e.g., "lontium,lt9211") if the
devices are sufficiently compatible, or is a driver update missing from this
series?

> +		reg = <0x2d>;
> +		reset-gpios = <&tlmm 37 GPIO_ACTIVE_HIGH>;
> +		vccio-supply = <&vreg_s4a>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1