Re: [PATCH v4 2/7] riscv: dts: eswin: add clock generator for EIC7700 SoC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added 'fixed-clock' node uses the deprecated node name 'oscillator'. According to the fixed-clock DT bindings, the node name should match the pattern '^clock-([0-9]+|[a-z0-9-]+)$' (e.g., 'clock-24m'). The name 'oscillator' is marked as deprecated in the schema and will trigger a dtbs_check warning.
--

--- Patch [2]: [PATCH v4 2/7] riscv: dts: eswin: add clock generator for EIC7700 SoC ---
commit 2b4ebcd54553e592642ebabb9a2f8063cbd1f050
Author: Pritesh Patel <[email protected]>

riscv: dts: eswin: add clock generator for EIC7700 SoC

This commit adds the clock generator node for the EIC7700 SoC. It also configures
a 24MHz crystal oscillator to provide the input clock for HiFive Premier P550 boards.

> diff --git a/arch/riscv/boot/dts/eswin/eic7700.dtsi b/arch/riscv/boot/dts/eswin/eic7700.dtsi
> --- a/arch/riscv/boot/dts/eswin/eic7700.dtsi
> +++ b/arch/riscv/boot/dts/eswin/eic7700.dtsi

[ ... ]

> @@ -203,6 +204,11 @@ pmu {
>  				<0x00000000 0x0000000f 0xfffffffc 0x000000ff 0x00000078>;
>  	};
>  
> +	osc: oscillator {
> +		compatible = "fixed-clock";

[Severity: Low]
This isn't a bug, but does the node name "oscillator" trigger a dtbs_check
warning during validation? 

According to the fixed-clock DT bindings, the node name "oscillator" is 
marked as deprecated. The schema expects a pattern matching 
"^clock-([0-9]+|[a-z0-9-]+)$", for example, "clock-24m".

> +		#clock-cells = <0>;
> +	};
> +
>  	soc {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2