Re: [PATCH net-next v5 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML device tree example will fail compilation during `make dt_binding_check` due to unresolved phandles (`<&eth1_pins>` and `<&gpio>`).
--

--- Patch [1]: [PATCH net-next v5 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema ---
commit fcc3d575c269eac63488595e1b5b27fd36f552f7
Author: Arthur Crepin Leblond <[email protected]>

dt-bindings: net: wiznet,w5100: convert to DT schema

Convert the Wiznet w5x00 SPI Ethernet controller binding from
plain text to DT schema.

> diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> new file mode 100644
> index 0000000000000..217f301db182b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml

[ ... ]

> +examples:
> +  - |
> +    /* Example (for Raspberry Pi with pin control stuff for GPIO irq) */
> +
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet@0 {
> +            compatible = "wiznet,w5500";
> +            reg = <0>;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&eth1_pins>;
> +            interrupt-parent = <&gpio>;

[Severity: Low]
Will this example fail compilation during make dt_binding_check due to
unresolved phandles? It looks like &eth1_pins and &gpio are referenced
here, but their node definitions were not carried over from the original
text binding.

> +            interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> +            spi-max-frequency = <30000000>;
> +            local-mac-address = [ a0 b0 c0 d0 e0 f0 ];
> +        };
> +    };
> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1