Re: [PATCH 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#address-cells` and `#size-cells` in the `&sdhci` node causes the `wifi@1` child node's `reg` property to be malformed, triggering dtc compilation warnings.
--

--- Patch [2]: [PATCH 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint ---
commit 28267c9e17b352aed9318b01c48207c391929954
Author: Georgi Valkov <[email protected]>

ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint

This commit adds the marvell,ignore-regulatory-hint flag to the WRT3200ACM
device tree. It creates a new wifi@1 child node within the sdhci node to
instruct mwifiex to ignore incorrect regulatory hints from ROM.

> diff --git a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> index 4ab45f294de22..c5f94463ef710 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> @@ -165,6 +165,12 @@ &sdhci {
>  	wp-inverted;
>  	bus-width = <8>;
>  	status = "okay";
> +
> +	wifi@1 {
> +		compatible = "marvell,sd8897";
> +		reg = <1>;

[Severity: Low]
Does the parent &sdhci node need #address-cells = <1>; and #size-cells = <0>;
defined so the dtc compiler can correctly parse the reg = <1>; property?

Without these, dtc falls back to default cell sizes, which can cause
compilation warnings about invalid property lengths.

> +		marvell,ignore-regulatory-hint;
> +	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2