Re: [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Conor Dooley <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260814-cubical-transpire-413101a0c4c2@spud> |
On Fri, Aug 14, 2026 at 05:21:53PM +0530, Shubham Patil wrote: > In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C > IP. Describe them with two boolean properties. > > A Hot-Join request is acknowledged by the IBI machinery, so a hot-join > capable design is always IBI capable as well. Both events are reported > through the controller interrupt, which is therefore required whenever > the capability is present. > > Signed-off-by: Shubham Patil <[email protected]> > --- > .../bindings/i3c/xlnx,axi-i3c-1.0.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml > index 2caa245a8656..07e3d0b4d767 100644 > --- a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml > +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml > @@ -32,13 +32,34 @@ properties: > interrupts: > maxItems: 1 > > + xlnx,ibi-capable: > + type: boolean > + description: > + The IP is synthesized with In-Band Interrupt support. IBIs are reported > + through the controller interrupt. > + > + xlnx,hj-capable: tbh, I'd prefer if these were spelt out a little bit more, characters are cheap. Not a big deal though. > + type: boolean > + description: > + The IP is synthesized with Hot-Join support. A Hot-Join request is > + acknowledged by the same machinery as an In-Band Interrupt. > + > required: > - compatible > - reg > - clocks > > +dependencies: > + xlnx,hj-capable: ["xlnx,ibi-capable"] > + > allOf: > - $ref: i3c.yaml# > + - if: > + required: > + - xlnx,ibi-capable > + then: > + required: > + - interrupts Why is one dependency expressed this way, and the other expressed using the dependencies property? Can the interrupts property be handled that way too? Cheers, Conor. > > unevaluatedProperties: false > > @@ -54,5 +75,7 @@ examples: > interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; > #address-cells = <3>; > #size-cells = <0>; > + xlnx,ibi-capable; > + xlnx,hj-capable; > }; > ... > -- > 2.34.1 >
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCan82egAKCRB4tDGHoIJi 0iQrAQCs8qebR4quXdJpbjsXqfeQ608+ln1zNqvEfX7zedYCOAD/cYD8S+Ph/N6i 2fWFRkepRMirbphPDInTh0ZEKaL38Aw= =GetW -----END PGP SIGNATURE-----