Re: [PATCH v4 5/7] iio: light: ltr501: Fix duplicated error message

On Mon, 10 Aug 2026 09:11:15 +0200
Esben Haabendal <[email protected]> wrote:

> The dev_err() message was causing duplicated error messages, as
> devm_request_threaded_irq() calls dev_err_probe() on failure.
> 
> Fixes: 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
Not a fix.  This is tidying up.  All good, but we don't want anyone
to think this is something to backport.

So drop the Fixes tag and tweak the patch title to not say it is a fix.

Drop duplicated error message
or something like that.

Thanks,

Jonathan

> Cc: [email protected]
> Acked-by: Kuppuswamy Sathyanarayanan <[email protected]>
> Signed-off-by: Esben Haabendal <[email protected]>
> ---
>  drivers/iio/light/ltr501.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index 7746d374688f..b36bd10a0262 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c
> @@ -1537,11 +1537,8 @@ static int ltr501_probe(struct i2c_client *client)
>  						IRQF_ONESHOT,
>  						"ltr501_thresh_event",
>  						indio_dev);
> -		if (ret) {
> -			dev_err(&client->dev, "request irq (%d) failed\n",
> -				client->irq);
> +		if (ret)
>  			goto powerdown_on_error;
> -		}
>  	} else {
>  		indio_dev->info = data->chip_info->info_no_irq;
>  	}
>