Re: [PATCH 1/8] dt-bindings: remoteproc: qcom,nord-pas: Add qcom,cluster-root property

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `qcom,cluster-root` property is strictly required for ADSP cluster members but is omitted from the `required` schema list, and the example is not updated.
--

--- Patch [1]: [PATCH 1/8] dt-bindings: remoteproc: qcom,nord-pas: Add qcom,cluster-root property ---
commit fca9b39c4393ef8848adae4c6b55bac6904bfd95
Author: Shawn Guo <[email protected]>

dt-bindings: remoteproc: qcom,nord-pas: Add qcom,cluster-root property

Document the qcom,cluster-root phandle property used to describe HPASS's
ADSP0/1/2 cluster relationship. Every member of a cluster carries the
property, including the instance owning the shared resources, which
references itself; instances referencing the same node form one cluster
that boots in order and is torn down as a single unit.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
[ ... ]
> @@ -101,6 +116,8 @@ allOf:
>          compatible:
>            enum:
>              - qcom,nord-adsp-pas
> +            - qcom,nord-adsp1-pas
> +            - qcom,nord-adsp2-pas
>      then:
>        properties:
>          power-domains:

[Severity: Medium]
Since qcom,cluster-root is strictly required for ADSP cluster members,
should it be added to the required list in this conditional block?

If an ADSP node is created without the property, it will silently pass
make dt_binding_check. At runtime, a missing qcom,cluster-root property can
cause the DSP driver to fail to establish the cluster relationship,
potentially hanging the boot process of ADSP1/ADSP2.

Additionally, the existing example node at the end of the file lacks the
qcom,cluster-root property:

Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml:
examples:
  - |
    ...
    remoteproc@4c00000 {
        compatible = "qcom,nord-adsp-pas";
        reg = <0x04c00000 0x10000>;
    ...

Could the example be updated to include a self-referencing
qcom,cluster-root property to conform to this new requirement?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1