Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a compilation failure because the macro `QCOM_ID_SM7250` is undeclared. The macro `qcom_board_id(SM7250)` expands to `QCOM_ID_SM7250`, which is not defined in `include/dt-bindings/arm/qcom,ids.h` or anywhere else in the tree.
--
--- Patch [1]: [PATCH 1/2] soc: qcom: socinfo: Add SM7250 SoC ID ---
commit 8ca1fecd3b445847ec519f60e57b6e9de9904c54
Author: Sreeshankar K <[email protected]>
soc: qcom: socinfo: Add SM7250 SoC ID
This commit adds the SoC ID for the Qualcomm SM7250 SoC to the socinfo driver.
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index af418adad7aaf..54b1f8e1b9359 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -449,6 +449,7 @@ static const struct soc_id soc_id[] = {
> { qcom_board_id(IPQ8172) },
> { qcom_board_id(IPQ8173) },
> { qcom_board_id(IPQ8174) },
> + { qcom_board_id(SM7250) },
[Severity: Low]
Does this cause a compilation failure? The qcom_board_id(SM7250) macro
expands to QCOM_ID_SM7250, but it appears that QCOM_ID_SM7250 is not defined
in include/dt-bindings/arm/qcom,ids.h or anywhere else in the tree.
> { qcom_board_id(IPQ6018) },
> { qcom_board_id(IPQ6028) },
> { qcom_board_id(SDM429W) },
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.