Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The invalid compatible string `asrock,x470d4u-data64-bmc` is improperly added to the dt-bindings UAPI.
--
--- Patch [1]: [PATCH v4 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC ---
commit d0559c4cf1eefd31825e79b49e2443b883b69be6
Author: Tan Siewert <[email protected]>
dt-bindings: arm: aspeed: add ASRock X470D4U BMC
This commit documents ASRock's X470D4U BMC board compatibles in the Aspeed
device tree binding schema.
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -40,6 +40,8 @@ properties:
> - asrock,e3c256d4i-bmc
> - asrock,romed8hm3-bmc
> - asrock,spc621d8hm3-bmc
> + - asrock,x470d4u-bmc
> + - asrock,x470d4u-data64-bmc
[Severity: Low]
Is this compatible string factually correct for ASRock hardware?
The "-data64" suffix is typically used exclusively by Facebook/Meta hardware
to denote a specific 64MB SPI NOR flash layout in OpenBMC (e.g.,
"facebook,wedge400-data64-bmc").
Could this pollute the stable UAPI/dt-binding schema with a fictitious
device configuration for standard ASRock X470D4U hardware?
> - asrock,x570d4u-bmc
> - bytedance,g220a-bmc
> - facebook,cmm-bmc
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.