Re:[PATCH v11 05/21] drm/bridge: synopsys: dw-dp: Add missing mutex cleanups on module removal
"Andy Yan" <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Sebastian, At 2026-08-07 01:02:11, "Sebastian Reichel" <[email protected]> wrote: >The driver is currently missing to fully clean up after itself. Ensure >that the mutex is cleaned up. > >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") >Reported-by: Sashiko <[email protected]> >Signed-off-by: Sebastian Reichel <[email protected]> Reviewed-by: Andy Yan <[email protected]> >--- > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c >index 52e3b37259a6..b1856418f441 100644 >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c >@@ -2040,10 +2040,13 @@ struct dw_dp *dw_dp_probe(struct platform_device *pdev, const struct dw_dp_plat_ > dp->pixel_mode = plat_data->pixel_mode; > dp->plat_data.max_link_rate = plat_data->max_link_rate; > >- mutex_init(&dp->irq_lock); > INIT_WORK(&dp->hpd_work, dw_dp_hpd_work); > init_completion(&dp->complete); > >+ ret = devm_mutex_init(dev, &dp->irq_lock); >+ if (ret) >+ return ERR_PTR(ret); >+ > res = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(res)) > return ERR_CAST(res); > >-- >2.53.0 > > >_______________________________________________ >Linux-rockchip mailing list >[email protected] >http://lists.infradead.org/mailman/listinfo/linux-rockchip