Re:[PATCH v11 08/21] drm/bridge: synopsys: dw-dp: Free output_fmts when none are valid
"Andy Yan" <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Sebastian, At 2026-08-07 01:02:14, "Sebastian Reichel" <[email protected]> wrote: >If dw_dp_bandwidth_ok() returns false for all formats, *num_output_fmts >might end up becoming 0. In this case functions calling it assume that >nothing needs to be free'd, so free output_fmts within the function to >avoid leaking memory. > >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") >Reported-by: Sashiko <[email protected]> >Signed-off-by: Sebastian Reichel <[email protected]> Reviewed-by: Andy Yan <[email protected]> >--- > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c >index 8ceb139f1a72..d35dcd4a413f 100644 >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c >@@ -1820,6 +1820,11 @@ static u32 *dw_dp_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, > output_fmts[j++] = fmt->bus_format; > } > >+ if (j == 0) { >+ kfree(output_fmts); >+ output_fmts = NULL; >+ } >+ > *num_output_fmts = j; > > return output_fmts; > >-- >2.53.0 > > >_______________________________________________ >Linux-rockchip mailing list >[email protected] >http://lists.infradead.org/mailman/listinfo/linux-rockchip