Re: [PATCH v3 3/4] arm64: dts: rockchip: Add crypto node to rk356x-base

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `crypto` device tree node is missing the `status = "disabled";` property, contradicting the commit message and enabling it by default on all boards.
--

--- Patch [3]: [PATCH v3 3/4] arm64: dts: rockchip: Add crypto node to rk356x-base ---
commit 452b9449e76bd94304ad239887547298226d6bf8
Author: Dawid Olesinski <[email protected]>

arm64: dts: rockchip: Add crypto node to rk356x-base

This commit adds the device tree node for the V2 cryptographic hardware
accelerator on RK356x SoCs to the base dtsi file. The commit message notes
that the node is disabled by default and should be enabled by board files
that wish to use hardware crypto offload.

> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
[ ... ]
> @@ -1112,6 +1112,17 @@ sdhci: mmc@fe310000 {
>  		status = "disabled";
>  	};
>  
> +	crypto: crypto@fe380000 {
> +		compatible = "rockchip,rk3568-crypto";
> +		reg = <0x0 0xfe380000 0x0 0x2000>;
> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru CLK_CRYPTO_NS_CORE>, <&cru ACLK_CRYPTO_NS>,
> +			 <&cru HCLK_CRYPTO_NS>;
> +		clock-names = "core", "aclk", "hclk";
> +		resets = <&cru SRST_CRYPTO_NS_CORE>;
> +		reset-names = "core";
> +	};

[Severity: Medium]
Does this node need a status = "disabled"; property to match the commit
message?

The commit message states: "The node is disabled by default; board files
that wish to use hardware crypto offload must enable it." 

Because device tree nodes default to "okay" when the status property is
omitted, the lack of status = "disabled" here will cause the cryptographic
offloader driver to automatically probe on all RK356x boards that include
rk356x-base.dtsi, rather than requiring board files to enable it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3