Re: [PATCH v3 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit documents `out_current[Y]_powerdown_mode` and `out_current[Y]_powerdown` but fails to document the corresponding `out_current[Y]_powerdown_mode_available` attributes. -- --- Patch [1]: [PATCH v3 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode --- commit 3e8e143ec75a90ed9c1acf741435fcedffa2116c Author: Kim Seer Paller <[email protected]> iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode This commit documents the out_currentY_powerdown and out_currentY_powerdown_mode attributes for current-output DAC channels, and adds the 15kohm_to_gnd powerdown mode. > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index a4f5595722ade..a0f9aada5c62d 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -762,6 +762,8 @@ What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode > What: /sys/bus/iio/devices/iio:deviceX/out_voltage_powerdown_mode > What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_powerdown_mode > What: /sys/bus/iio/devices/iio:deviceX/out_altvoltage_powerdown_mode > +What: /sys/bus/iio/devices/iio:deviceX/out_currentY_powerdown_mode > +What: /sys/bus/iio/devices/iio:deviceX/out_current_powerdown_mode [Severity: Low] Since this commit documents out_current[Y]_powerdown_mode, should the corresponding out_current[Y]_powerdown_mode_available attributes also be documented? The existing file has the available powerdown modes documented for voltage outputs nearby: What: /sys/.../iio:deviceX/out_voltageY_powerdown_mode_available What: /sys/.../iio:deviceX/out_voltage_powerdown_mode_available What: /sys/.../iio:deviceX/out_altvoltageY_powerdown_mode_available What: /sys/.../iio:deviceX/out_altvoltage_powerdown_mode_available -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1