Re: [PATCH v3 2/4] dt-bindings: iio: dac: add adi,ad5710r.yaml

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The device tree binding uses a global custom boolean property (`adi,range-double`) to configure the output range for all channels simultaneously, which contradicts the hardware's per-channel capability and ignores the standard IIO properties.
- [Low] The new device tree binding is incorrectly grouped under an unrelated driver section in the MAINTAINERS file.
--

--- Patch [2]: [PATCH v3 2/4] dt-bindings: iio: dac: add adi,ad5710r.yaml ---
commit b2de4e5383bdec1581e94efdee27327a62fd9078
Author: Kim Seer Paller <[email protected]>

dt-bindings: iio: dac: add adi,ad5710r.yaml

Add device tree bindings for the Analog Devices AD5710R/AD5711R
8-channel 12-/16-bit Configurable IDAC/VDAC.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml
> new file mode 100644
> index 0000000000000..259866ca87cff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml

[ ... ]

> +  ldac-gpios:
> +    description:
> +      LDAC pin to be used as a hardware trigger to update the DAC channels. If
> +      not present, the DAC channels are updated by Software LDAC.
> +    maxItems: 1
> +
> +  adi,range-double:
> +    description:
> +      Configure the output range for all channels. If the property is present,
> +      the output will range from 0V to 2 x Vref. If the property is not present,
> +      the output will range from 0V to Vref.
> +    type: boolean

[Severity: Medium]
Does this global custom property restrict the per-channel hardware capability
and ignore standard IIO range properties?

The binding description earlier in this file states "Each channel can be
independently configured as a voltage output (0V to VREF or 0V to 2 x VREF)".
However, `adi,range-double` is defined here as a global setting, which prevents
configuring voltage ranges independently for different channels.

Would it be better to move this to the per-channel `patternProperties` and
utilize the standard IIO property `output-range-microvolt` instead of a custom
boolean?

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3c5084fec2023..bed05d0cccb73 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1444,6 +1444,7 @@ L:	[email protected]
>  S:	Supported
>  W:	https://ez.analog.com/linux-software-drivers
>  F:	Documentation/devicetree/bindings/iio/dac/adi,ad3530r.yaml
> +F:	Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml

[Severity: Low]
This isn't a bug, but is the new device tree binding incorrectly grouped
under an unrelated driver section?

The `adi,ad5710r.yaml` file appears to be appended to the
"ANALOG DEVICES INC AD3530R DRIVER" section, which could be misleading
when using standard maintainer tools.

>  F:	drivers/iio/dac/ad3530r.c
>  
>  ANALOG DEVICES INC AD3552R DRIVER

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2