Re: [PATCH v4 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] The QMP PHY vdda-phy-supply and vdda-pll-supply regulators are swapped on all USB PHY nodes, supplying 1.2V to the 0.9V core and 0.9V to the 1.2V PLL.
--

--- Patch [2]: [PATCH v4 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI ---
commit 202cffb7469000f285c774f7cd690578bdee2992
Author: Jason Pettit <[email protected]>
Subject: arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

Add board support for the HP EliteBook X G2q 14" Next Gen AI PC
(Snapdragon X2 Elite / Glymur). This includes support for the internal
eDP panel, USB Type-C, chassis HDMI, USB-A host, NVMe, and other internal
peripherals.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts
> new file mode 100644
> index 0000000000000..7993f0e70fc00
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts
> @@ -0,0 +1,1032 @@

[ ... ]

> +&usb_0_qmpphy {
> +	vdda-phy-supply = <&vreg_l4h_e0_1p2>;
> +	vdda-pll-supply = <&vreg_l3f_e0_0p91>;
> +	refgen-supply = <&vreg_l2f_e0_0p94>;
> +
> +	status = "okay";
> +};

[Severity: Critical]
Are the regulators for the QMP PHY swapped here?

Supplying 1.2V to the 0.9V core (vdda-phy-supply) causes an overvoltage that
can physically damage the hardware.

Additionally, supplying 0.91V to the 1.2V PLL (vdda-pll-supply) means the PLL
will fail to lock, rendering the USB interface non-functional.

[ ... ]

> +&usb_1_qmpphy {
> +	vdda-phy-supply = <&vreg_l4h_e0_1p2>;
> +	vdda-pll-supply = <&vreg_l1h_e0_0p94>;
> +	refgen-supply = <&vreg_l2f_e0_0p94>;
> +
> +	status = "okay";
> +};

[Severity: Critical]
Could the regulators for this QMP PHY also be swapped?

Just like usb_0_qmpphy, it appears 1.2V is being supplied to the 0.9V core and
0.94V is being supplied to the 1.2V PLL.

[ ... ]

> +&usb_2_qmpphy {
> +	vdda-phy-supply = <&vreg_l4h_e0_1p2>;
> +	vdda-pll-supply = <&vreg_l3f_e0_0p91>;
> +	refgen-supply = <&vreg_l2f_e0_0p94>;
> +
> +	/delete-property/ mode-switch;
> +	/delete-property/ orientation-switch;
> +
> +	status = "okay";

[Severity: Critical]
Does this PHY also have the supplies swapped between the 0.9V core and
the 1.2V PLL?

[ ... ]

> +&usb_mp_qmpphy0 {
> +	vdda-phy-supply = <&vreg_l4h_e0_1p2>;
> +	vdda-pll-supply = <&vreg_l2h_e0_0p88>;
> +	refgen-supply = <&vreg_l4f_e1_1p2>;
> +
> +	status = "okay";
> +};

[Severity: Critical]
Are the supplies swapped on this PHY as well, causing an overvoltage on the
0.9V core?

[ ... ]

> +&usb_mp_qmpphy1 {
> +	vdda-phy-supply = <&vreg_l4h_e0_1p2>;
> +	vdda-pll-supply = <&vreg_l2h_e0_0p88>;
> +	refgen-supply = <&vreg_l4f_e1_1p2>;
> +
> +	status = "okay";
> +};

[Severity: Critical]
And here as well? It looks like the same swap pattern applies to all the
USB PHY nodes in this board device tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2