Re: [PATCH net-next v14 05/13] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus

>  error:
> -	/* phy_detach() does all of the cleanup below */
> -	phy_detach(phydev);
> +	/* cleanup without bus notification */
> +	phy_detach_internal(phydev, false);
>  	return err;

This looses the "does all of the cleanup below".

This code is unusual. You normally don't call the mirror function in
the error path. So i think it would be good to keep the comment.

    Andrew