Re: [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint

[email protected]
Newsgroups org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit adds the device tree property `marvell,ignore-regulatory-hint` to the WRT3200ACM DTS, but the corresponding parser and logic in the `mwifiex` driver is missing from the tree.
--

--- Patch [2]: [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint ---
commit f221d0ed898a6646fd79f05bc58d44fefe8c2296
Author: Georgi Valkov <[email protected]>

ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint

This commit adds the marvell,ignore-regulatory-hint property to the WRT3200ACM
device tree. The property signals the mwifiex driver to ignore an incorrect
regulatory hint from the ROM, allowing userspace to set the correct platform
regulatory domain.

> diff --git a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> index 4ab45f294de22..b93c5c419962f 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> @@ -165,6 +165,15 @@ &sdhci {
>  	wp-inverted;
>  	bus-width = <8>;
>  	status = "okay";
> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	wifi@1 {
> +		compatible = "marvell,sd8897";
> +		reg = <1>;
> +		marvell,ignore-regulatory-hint;

[Severity: Medium]
Is the corresponding parser and logic for this property missing from the kernel
tree?

It doesn't appear there is any support for the marvell,ignore-regulatory-hint
property added to wifi@1 in the mainline mwifiex driver. Since the property is
not parsed anywhere, the regulatory conflict won't be resolved and the 5 GHz
radio will remain restricted when booting with this device tree.

Are there plans to send a companion patch to the wireless tree to actually
implement this feature?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.