Re: [PATCH v5 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new compatible string `altr,socfpga-stmmac-agilex5-tsn` was omitted from the `if-then` conditional block that configures Agilex5 hardware constraints, causing incorrect schema validation constraints.
--

--- Patch [3]: [PATCH v5 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible ---
commit 2c9b079b75feaedbd6e75247894304aafdd870f8
Author: Nazim Amirul <[email protected]>

dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible

This commit adds the altr,socfpga-stmmac-agilex5-tsn compatible string for the
Agilex5 SoCDK TSN Config2 gmac1 path. The integration includes an FPGA soft-IP
GMII-to-RGMII converter between the DWXGMAC and the PHY.

> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index 63084f7623738..7db6a71029943 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
[ ... ]
> @@ -46,6 +47,9 @@ properties:
>        - items:
>            - const: altr,socfpga-stmmac-agilex5
>            - const: snps,dwxgmac-2.10
> +      - items:
> +          - const: altr,socfpga-stmmac-agilex5-tsn
> +          - const: snps,dwxgmac-2.10
>  
>    clocks:
>      minItems: 1

[Severity: Medium]
Should altr,socfpga-stmmac-agilex5-tsn also be added to the allOf conditional
block for Agilex5 devices further down in the file?

Currently, the conditional block enforces constraints specifically for Agilex5:

  - if:
      properties:
        compatible:
          contains:
            const: altr,socfpga-stmmac-agilex5
    then:
      properties:
        interrupts:
          minItems: 17

Since the new compatible string is omitted here, won't valid device trees
using the new tsn variant fail schema validation because they fall into the
else branch, which incorrectly applies interrupts: maxItems: 1 and
dma-coherent: false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817030213.6769-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=3