Re: [PATCH v7 2/4] iio: light: add support for veml6031x00 ALS series
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Tue, Aug 18, 2026 at 01:34:27PM +0200, Javier Carrasco wrote:
> Support device identification, raw ALS and IR readings, and configuration
> of the scale and integration time.
...
> +static void veml6031x00_als_shutdown_action(void *data)
> +{
> + struct veml6031x00_data *priv = data;
struct device *dev = regmap_get_device(priv->regmap);
> + int ret;
> +
> + ret = veml6031x00_set_power(priv, false);
> + if (ret)
> + dev_warn(regmap_get_device(priv->regmap),
> + "Failed to shut down device: %d\n", ret);
dev_warn(dev, "Failed to shut down device: %d\n", ret);
> +}
Same amount of LoC, but more flexible and scalable.
...
No need to resend just for this, the rest seems fine to me.
--
With Best Regards,
Andy Shevchenko