Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Placeholder DT nodes omit mandatory properties (e.g. `compatible`), causing schema validation failures.
- [Low] Newly added USB device tree nodes are not sorted by unit-address.
--
--- Patch [1]: [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add USB2.0 placeholder nodes ---
commit cc298f15a0f37ec626ccaf22949b2e2fb488034f
Author: Tommaso Merciai <[email protected]>
arm64: dts: renesas: r9a08g046: Add USB2.0 placeholder nodes
This commit adds placeholder USB2.0 devicetree nodes to the RZ/G3L SoC DTSI.
It resolves build errors caused by the shared SMARC Carrier-II board file
enabling these nodes. The nodes currently only contain the reg property.
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> index c63a857f0e5b0..5951a68c981cb 100644
> --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
[ ... ]
> @@ -1001,6 +1001,31 @@ queue3 {
> };
> };
>
> + ohci0: usb@11e10000 {
> + reg = <0 0x11e10000 0 0x100>;
> + /* placeholder */
> + };
[Severity: Medium]
Will these placeholder nodes cause devicetree schema validation failures?
Since they omit mandatory properties like compatible strings, compiling the
devicetree with dtbs_check enabled might produce structurally invalid nodes.
Because the shared board file enables them, they could be treated as malformed
active devices. Could the basic required properties be included now?
> +
> + ohci1: usb@11e90000 {
> + reg = <0 0x11e90000 0 0x100>;
> + /* placeholder */
> + };
> +
> + ehci0: usb@11e10100 {
[Severity: Low]
This isn't a bug, but should these nodes be sorted by their unit-address?
The ohci1 node at usb@11e90000 is placed before ehci0 at usb@11e10100, which
breaks the ascending numerical address ordering convention. Sorting them as
usb@11e10000, usb@11e10100, usb@11e30000, pcie@11e40000, usb@11e90000, and
usb@11e90100 might be preferred.
> + reg = <0 0x11e10100 0 0x100>;
> + /* placeholder */
> + };
> +
> + ehci1: usb@11e90100 {
> + reg = <0 0x11e90100 0 0x100>;
> + /* placeholder */
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.