Re: [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds the `samsung,exynos5515-chipid` compatible string with a fallback to `samsung,exynos850-chipid`, but omits the necessary driver update to support the new SoC. The `exynos-chipid` driver enforces a strict hardware whitelist based on the product ID and will return `-ENODEV` during probe when it encounters the unknown Exynos 5515 ID, rendering the fallback useless.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible ---
commit c6d7dc985bd68c7bd5ad1ca061556d7ae1c7ee31
Author: Aiden Isik <[email protected]>
Subject: dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible

This commit adds the samsung,exynos5515-chipid compatible string to the
exynos-chipid device tree bindings documentation.

> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index b9cdfe52b62ff..619faf33214bd 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> @@ -25,6 +25,7 @@ properties:
>        - items:
>            - enum:
>                - samsung,exynos2200-chipid
> +              - samsung,exynos5515-chipid

[Severity: Medium]
Will this compatible string actually allow the driver to probe on Exynos 5515
hardware?

Even with a fallback to samsung,exynos850-chipid, the exynos-chipid driver
enforces a strict hardware whitelist based on the product ID:

drivers/soc/samsung/exynos-chipid.c:exynos_chipid_probe() {
    ...
    soc_dev_attr->soc_id = exynos_product_id_to_name(soc_info.product_id);
    if (!soc_dev_attr->soc_id)
        return dev_err_probe(dev, -ENODEV, "Unknown SoC\n");
    ...
}

Does this require a corresponding driver update to add the Exynos 5515 product
ID to the whitelist so the probe does not fail with -ENODEV?

>                - samsung,exynos7885-chipid
>                - samsung,exynos8895-chipid
>                - samsung,exynos9610-chipid

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1