Re: [PATCH v3 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

On 8/17/26 9:00 AM, Krzysztof Kozlowski wrote:

[...]

>> +  clocks:
>> +    maxItems: 1
>> +
>> +  dr_mode:
> 
> We don't accept properties with underscores, unless this is coming from
> existing schema but I do not see snps,dwc referenced in the binding.

As suggested later in this thread, ref: snps,dwc3-common.yaml makes this 
whole thing go away, so fixed in V4, thanks .

>> +    enum: [ host, otg, peripheral ]
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  maximum-speed:
> 
> Again, where is the property defined?

usb.yaml , which is pulled in via snps,dwc3-common.yaml in V4 and this 
is dropped.

>> +    enum: [ super-speed-plus, super-speed, high-speed ]
>> +
>> +  phys:
>> +    minItems: 1
>> +    maxItems: 2
> 
> Why is this flexible?

The SoC has four controller instances, two instances only have USB 2.0 
PHY connected to them, and two have both USB 2.0 and USB 3.2 PHYs .

>> +  phy-names:
>> +    minItems: 1
>> +    items:
>> +      - const: usb2-phy
> 
> phy is redundant. Are you implementing completely new bindings which
> have nothing in common with all others?
No, and both phys and phy-names is dropped by pulling in 
snps,dwc3-common.yaml , thanks !