Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding `raspberrypi,dsi-10inch` without conditional blocks unconditionally forces incorrect hardware constraints (discrete supplies and enable-gpios) onto the new panel variant.
--
--- Patch [1]: [PATCH v2 1/4] dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2 ---
commit 2739ad573af941325eae5c172cd4464d44cc6055
Author: Marek Vasut <[email protected]>
dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2
This commit documents the 10" Raspberry Pi Touch Display 2 MIPI-DSI TFT
LCD panel. The panel is based on the Ilitek ILI79600A controller.
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> index 02f7fb1f16dc7..f8644e9a4478d 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> @@ -14,10 +14,15 @@ allOf:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - tianma,tl121bvms07-00
> - - const: ilitek,il79900a
> + oneOf:
> + - items:
> + - enum:
> + - raspberrypi,dsi-10inch
> + - const: ilitek,ili79600a
[Severity: Medium]
Will this unconditionally force incorrect hardware constraints onto the new
panel variant?
Adding the compatible string here causes the raspberrypi,dsi-10inch panel
to inherit the global required properties present later in this file:
required:
- compatible
- reg
- enable-gpios
- avdd-supply
- avee-supply
- pp1800-supply
If device trees omit enable-gpios or the discrete supplies for this new
hardware variant, will they incorrectly fail dtbs_check schema validation?
Should the binding use conditional blocks to handle the different required
properties for each hardware variant?
> + - items:
> + - enum:
> + - tianma,tl121bvms07-00
> + - const: ilitek,il79900a
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.