Re: [PATCH v2 0/3] arm64: dts: qcom: shikra: Add CYPD6129/CYPD6229 Type-C controller support
Abel Vesa <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <s2ktdbck6jsb7eb2axjofhhxc57pqeslybqbgjuwmbjzjlt23s@rwkqmyfeqh2v> |
On 26-08-21 15:56:49, Akash Kumar wrote: > This series adds support for the Cypress cypd6129/cypd6229 dual > Type-C PD controllers used on the Shikra CQM/CQS/IQS platforms to > handle usb-role-switch, and wires up the corresponding DT nodes. > > Changes in v2: > - dt-bindings: add a top-level "wakeup-source" property on the > controller node (matching richtek,rt1719.yaml/ti,tps6598x.yaml) and > move "wakeup-source;" in the example out of "connector@0" onto the > parent node, since usb-connector.yaml ends in > "unevaluatedProperties: false" and does not itself declare > "wakeup-source" -- placing it inside the connector node fails > dtbs_check. Also fixed related whitespace nitpicks in the example. > - dts: apply the same wakeup-source relocation to all three affected > boards (shikra-cqm-evk, shikra-cqs-evk, shikra-iqs-evk). > - dts: fix shikra-iqs-evk's cypd6229 node to use the > "cypress,cypd6229", "cypress,cypd6129" fallback compatible string > pair required by the binding, instead of "cypress,cypd6229" alone. > - dts: fix shikra-cqm-evk/shikra-cqs-evk wiring so CYPD6129 connects > to usb_2_dwc3_hs (secondary port) and PM4125's built-in typec > connects to usb_1_dwc3_hs/pm4125_hs_in (primary port), and add the > missing reverse remote-endpoint links on pm4125_hs_in/pm4125_ss_in. > - No changes to patch 2/3 (driver match table). > > Link to v1: https://lore.kernel.org/all/[email protected]/ > > Signed-off-by: Akash Kumar <[email protected]> Please do not send as reply to earlier revisions.