Re: [PATCH v3 3/7] arm64: dts: qcom: Add Motorola One

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing touchscreen device node despite being claimed as supported in the commit message.
- [Low] Invalid node names for 'regulator-fixed' devices failing schema validation.
--

--- Patch [3]: [PATCH v3 3/7] arm64: dts: qcom: Add Motorola One ---
commit 8ba9a47fea266dad9cdd80e285fa6a60029f2405
Author: Adam Skladowski <[email protected]>

arm64: dts: qcom: Add Motorola One

Add a devicetree for the Motorola One smartphone, which is based
on the Jacala/MSM8953 SoC.

>     Supported functionality as of this initial submission:
>     * I2C peripherals (Touchscreen,NFC)

[Severity: Medium]
The commit message mentions touchscreen support, but it appears the device
node is missing from the I2C buses in the device tree. Are the touchscreen
nodes missing from this submission?

> diff --git a/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts b/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts
> new file mode 100644
> index 0000000000000..66ecfab69c365
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts
[ ... ]
> +	vph_pwr: vph-pwr-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vph_pwr";
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	/* Fake VBUS 5V supply till we wire pmi8950 one */
> +	fusb302_vbus: otg-vbus {
> +		compatible = "regulator-fixed";

[Severity: Low]
Will these node names cause dtbs_check warnings?

It looks like vph-pwr-regulator and otg-vbus do not match the required node
name pattern for fixed regulators in fixed-regulator.yaml. Should they
start with "regulator" to pass validation?

[ ... ]
> +&i2c_2 {
> +	status = "okay";
> +};
> +
> +&i2c_3 {
> +	status = "okay";
> +};

[Severity: Medium]
Are these I2C buses left empty because the intended touchscreen device node
is missing?

[ ... ]
> +	ts_int_default: ts-int-default-state {
> +		pins = "gpio65";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-pull-up;
> +	};

[Severity: Medium]
Since the touchscreen device node seems to be missing, are these pinctrl
configurations currently unused?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3