Re: [PATCH v5 7/7] arm64: dts: qcom: Add Xiaomi Redmi 9T

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree Misconfiguration: Invalid `brightness-levels` array in `led-backlight` node.
--

--- Patch [7]: [PATCH v5 7/7] arm64: dts: qcom: Add Xiaomi Redmi 9T ---
commit b28de55d5a8b36d66c2c9a970672b92796d38f43
Author: Adam Skladowski <[email protected]>

arm64: dts: qcom: Add Xiaomi Redmi 9T

This commit adds a new devicetree for the Xiaomi Redmi 9T smartphone based
on the Qualcomm SM6115 SoC. It enables foundational hardware support
including simple framebuffer, GPU, regulators, and USB, while leaving
display-dependent nodes disabled for now.

> diff --git a/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts
> new file mode 100644
> index 0000000000000..881e05b70116b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts

[ ... ]

> +	backlight_dsi: backlight-dsi {
> +		compatible = "led-backlight";
> +		leds = <&led_backlight>;
> +		brightness-levels = <255>;

[Severity: Low]
Is this single-element brightness-levels array intentional?

If the backlight_dsi node is later enabled by a panel variant, the
led-backlight driver will parse this property via led_bl_parse_levels().
Since it expects multiple levels, providing only one element causes the driver
to print a "Not enough levels defined" warning, ignore the property, and fall
back to native scaling.

Could this property be removed, or populated with the full array of expected
brightness levels?

> +		default-brightness-level = <190>;
> +		/* Backlight controllers can differ between panel variants */
> +		status = "disabled";
> +	};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7