Re: [PATCH 1/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding `vdda-supply = <&v3v3>;` in the base DK dtsi causes a dangling regulator reference in the SCMI variant `stm32mp157f-dk2.dts`, leading to indefinite probe deferral of the USB hub.
--

--- Patch [1]: [PATCH 1/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards ---
commit 7026553f1e1e9967635ef09d235c6eb6bc13f81a
Author: Fabrice Gasnier <[email protected]>

ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards

This commit fixes the regulator association for the vdda supply on the
Microchip USB2514 HUB used on stm32mp15 DK boards. It sets the vdda-supply
to use the v3v3 regulator, as the 3.3V regulator supplies both the digital
and analog parts of the hub.

> diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> index 599ea07bdb19c..01ac3d7d6d0ef 100644
> --- a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> @@ -764,6 +764,7 @@ hub@1 {
>  		compatible = "usb424,2514";
>  		reg = <1>;
>  		vdd-supply = <&v3v3>;
> +		vdda-supply = <&v3v3>;
[Severity: High]
Does adding this supply here without updating the SCMI variant cause probe
deferrals on stm32mp157f-dk2?

In arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi, vdd-supply is overridden
to use the SCMI regulator, but vdda-supply is missed:

&usbh_ehci {
	hub@1 {
		vdd-supply = <&scmi_v3v3>;
	};
};

Will this cause vdda-supply to inherit <&v3v3>, which points to a disabled
node in stm32mp157f-dk2.dts, and result in the hub indefinitely failing to
probe?

>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1