Re: [PATCH v3 1/2] dt-bindings: can: m_can: add out-band-wakeup property
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-can |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added `out-band-wakeup` property lacks a type definition, description, and the required vendor prefix. -- --- Patch [1]: [PATCH v3 1/2] dt-bindings: can: m_can: add out-band-wakeup property --- commit 18cc4cb55e5269767b220486da77c10e4826ca15 Author: Kendall Willis <[email protected]> dt-bindings: can: m_can: add out-band-wakeup property This commit adds the out-band-wakeup property to the bosch,m_can device tree binding. The property indicates that the device can wake up the system even when its power domain is off. > diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > index 2c9d37975bedd..0663beaa532bc 100644 > --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > @@ -150,6 +150,8 @@ properties: > description: > List of phandles to system idle states in which mcan can wakeup the system. > > + out-band-wakeup: true [Severity: Medium] Does this property need a type constraint and a vendor prefix? By defining the property merely as true, schema validation lacks the ability to enforce a specific data type, meaning it could silently allow arrays or strings instead of a boolean flag. Additionally, if this is a custom hardware property rather than a standard one, should it have a vendor prefix to avoid namespace pollution? > + > required: > - compatible > - reg -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1