Re: [PATCH v3 10/15] dt-bindings: clock: qcom: Add Kuno Global Clock Controller
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-clk |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The YAML binding requires `#power-domain-cells`, but no power domain macros (GDSCs) are defined in the header file, and the driver provides no implementation. -- --- Patch [10]: [PATCH v3 10/15] dt-bindings: clock: qcom: Add Kuno Global Clock Controller --- commit e8474d42563c99c569b8bb564eb4620691ab9a28 Author: Hardeep Sharma <[email protected]> dt-bindings: clock: qcom: Add Kuno Global Clock Controller Document the Global Clock Controller (GCC) binding and associated clock/reset IDs for the Qualcomm Kuno SoC. > diff --git a/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml [ ... ] > +required: > + - compatible > + - clocks > + - '#power-domain-cells' [Severity: Medium] Does this binding intend to enforce power domains for the Kuno GCC? The YAML binding requires '#power-domain-cells' here, but looking at the associated qcom,kuno-gcc.h header file, there are no power domain macros (GDSCs) defined. If the hardware does provide power domains, it seems the definitions are missing from the header. If it does not, this requirement will force device tree nodes to include meaningless boilerplate to pass validation. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10