Re: [PATCH] regulator: dt-bindings: ti,tps6586x: Convert to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example contains phandle references to undefined labels, which will cause `make dt_binding_check` to fail.
--

--- Patch [1]: [PATCH] regulator: dt-bindings: ti,tps6586x: Convert to DT schema ---
commit b755cd6cba207356ee219dac6c62ba31935acb54
Author: Bhargav Joshi <[email protected]>

regulator: dt-bindings: ti,tps6586x: Convert to DT schema

Convert Texas Instruments tps6586x regulator binding from text to DT
schema. Add child regulator node properties that were missing in the text
binding but used in existing DTS files.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> new file mode 100644
> index 0000000000000..82c3a3c811200
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml

[ ... ]

> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      pmic@34 {
> +          compatible = "ti,tps6586x";
> +          reg = <0x34>;
> +          interrupts = <0 88 0x4>;
> +
> +          #gpio-cells = <2>;
> +          gpio-controller;
> +
> +          ti,system-power-controller;
> +
> +          sys-supply = <&vdd_5v0_sys>;
> +          vin-sm0-supply = <&sys_reg>;
> +          vin-sm1-supply = <&sys_reg>;
> +          vin-sm2-supply = <&sys_reg>;
> +          vinldo01-supply = <&sm2_reg>;
> +          vinldo23-supply = <&sm2_reg>;
> +          vinldo4-supply = <&sm2_reg>;
> +          vinldo678-supply = <&sm2_reg>;
> +          vinldo9-supply = <&sm2_reg>;
> +
> +          regulators {
> +              sys {

[Severity: Low]
Will this example fail to compile during make dt_binding_check?

The phandles <&vdd_5v0_sys>, <&sys_reg>, and <&sm2_reg> are referenced here,
but the labels are not defined in the snippet.

In the old text binding, the sys_reg and sm2_reg labels were defined on the
child nodes (e.g., sys_reg: sys { ... }), but they appear to have been omitted
in this conversion.

> +                  regulator-name = "vdd_sys";
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1