Re: [PATCH] dt-bindings: pinctrl: ti,pinctrl-palmas: Convert to DT schema

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The legacy text binding file was not removed during the conversion to DT schema.
- [Low] The YAML example references an undefined phandle label, which will cause `dtc` to fail during `make dt_binding_check`.
--

--- Patch [1]: [PATCH] dt-bindings: pinctrl: ti,pinctrl-palmas: Convert to DT schema ---
commit 3f34affd1ba20a6449af4fb14e654c0936273292
Author: Bhargav Joshi <[email protected]>

dt-bindings: pinctrl: ti,pinctrl-palmas: Convert to DT schema

Convert TI Palmas pin control text binding to DT schema. The legacy
binding allowed any subnode name. Restrict them to standard prefixes to
prevent the validator from accidentally evaluating standard integer
properties (like phandle) as child nodes.

[Severity: Low]
Should the legacy text binding file
Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt have been
deleted in this commit?

Leaving the legacy text binding in the tree results in duplicate,
conflicting documentation for the same bindings.

> diff --git a/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
> new file mode 100644
> index 0000000000000..c07e3a782ef07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
[ ... ]
> +examples:
> +  - |
> +    pmic {
> +        pinctrl {
> +            compatible = "ti,tps65913-pinctrl";
> +            ti,palmas-enable-dvfs1;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&palmas_pins_state>;

[Severity: Low]
Will this undefined phandle label cause dtc to fail during make
dt_binding_check?

It appears the palmas_pins_state label was omitted from the pinmux node
definition during the conversion from the original text file.

> +
> +            pinmux {
> +                gpio0 {
> +                    pins = "gpio0";
> +                    function = "id";
> +                    bias-pull-up;
> +                };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1