Re: [PATCH v6 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios
David Lechner <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/22/26 2:36 PM, Taha Ed-Dafili wrote: >> This is one that is starting to emerging as a common name, so I would >> call it clear-gpios instead to match the same name on chips with a >> similar function. > > Worth noting Nuno asked for the opposite in v2 review, specifically > to match the datasheet's /CLR pin name: Normally I advocate for matching the pin name too. But there are some common things like reset-gpios where we try to always use the same name. This clear input seems to be one of those common things. > > https://lore.kernel.org/linux-iio/[email protected]/ > > Let me know which name you'd prefer given that context, and I'll > update it in v7. > > Best Regards, > Taha Ed-Dafili There is only one binding currently with clr-gpios (adi,ltc2688). And only one with clear-gpios (adi,ad5791). Plus at least two more coming soon [1] [2]. In [3], there is a /CLR pin, but we called it reset-gpios because it also resets the control registers. I didn't re-check the datasheets on all of these, but hopefully we are being consistent. [1]: https://lore.kernel.org/linux-iio/[email protected]/ [2]: https://lore.kernel.org/linux-iio/[email protected]/ [3]: https://lore.kernel.org/linux-iio/[email protected]/