Re: [PATCH v10 6/6] selftests/mm: add hwpoison-panic destructive test
"David Hildenbrand (Arm)" <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 7/29/26 00:07, Breno Leitao wrote: > On Tue, Jul 28, 2026 at 09:21:40PM +0200, David Hildenbrand (Arm) wrote: >> On 7/28/26 21:20, Andrew Morton wrote: >>> >>> >>> The bash script is still there, no known issues. >>> >>> We have the thing and tests are useful. I'd say retain it until the >>> rewrite-in-C happens? >> >> Nacked-by: David Hildenbrand <[email protected]> > > I have a draft of the selftest in C already and I will give it more bake > time, and I will submit it until EOW. IMHO there is no need to rush this test here, we could merge it after the main work. We neglected our selftests quite a bit in the past, and that is biting us now. That's why I push back hard now (sorry) against stuff that is different than the rest and not easy to maintain. I know, hwpoison-panic is a destructive test, but I really don't think we should just merge mostly unreviewed bash tests that will just bitrot. Which makes me wonder now: should this actually be a selftest? It's nothing one would just want to run in a CI. It will crash your machine. Maybe this should just be a tool in tools/mm? I really think so. So having a nice C-level hwpoison-panic.c in tools/mm might be the way to go. So let's rather make this test well maintainable and have it properly reviewed than rushing something suboptimal. -- Cheers, David