Re: [PATCH v7 4/4] hwmon: pmbus: mpq8646: gate the writes
Markus Elfring <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
> The write cases of debugfs entries are provisioning and bench > helpers. By designs the MPQ8646 powers the CPU core rail, > so a wrong write can brown out the board or persist a bad > setpoint into finite-cycle NVM. > Said differently: some wrong register writes can and likely > will physically damage or destroy the chip and/or the board. > > To be safe, it is disabled by default behind a > CONFIG_SENSORS_MPQ8646_DEBUG_UNSAFE and we print an explicit warning > banner at probe time when they are built in. See also once more: * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc5#n94 * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc5#n669 What did hinder you to take linked wording requirements better into account? Regards, Markus