Re: [PATCH 2/2] Docs/mm: fix THP policy counts in transhuge

On 8/12/26 5:27 PM, Lorenzo Stoakes (ARM) wrote:
> On Wed, Aug 12, 2026 at 04:03:13PM +0800, Song Hu wrote:
>> transhuge.rst claims seven policies for transparent_hugepage_shmem= and
>> four for transparent_hugepage_tmpfs=.  Both boot parameters are parsed by
>> shmem_parse_huge(), which accepts six: always, within_size, advise, never,
>> deny and force.  The "four" applies only to the per-mount huge= option
>> (shmem_param_enums_huge).  Fix both counts to six.
>>
>> Signed-off-by: Song Hu <[email protected]>
>> ---
>>   Documentation/admin-guide/mm/transhuge.rst | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
>> index b187d618452f..72e944f49da5 100644
>> --- a/Documentation/admin-guide/mm/transhuge.rst
>> +++ b/Documentation/admin-guide/mm/transhuge.rst
>> @@ -389,14 +389,14 @@ is not defined within a valid ``thp_anon``, its policy will default to
>>   Similarly to ``transparent_hugepage``, you can control the hugepage
>>   allocation policy for the internal shmem mount by using the kernel parameter
>>   ``transparent_hugepage_shmem=<policy>``, where ``<policy>`` is one of the
>> -seven valid policies for shmem (``always``, ``within_size``, ``advise``,
>> +six valid policies for shmem (``always``, ``within_size``, ``advise``,
>>   ``never``, ``deny``, and ``force``).
> 
> I'm not sure we really want to advertise 'special' testing modes like this,
> sorry. These are not modes anybody should be using in practice especially at
> kernel boot. We should probably stop people doing that...!

Yes, 'deny' and 'force' are testing-only configurations and really 
shouldn't be exposed via the kernel command line. I'll clean them up.