[PATCH net-next v3 0/7] netconsole: validate a target's IP address configuration
Gustavo Luiz Duarte <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
This series adds two validations to the target configuration when the user tries to enable it: first whether remote_ip was set, and second whether local_ip and remote_ip address families match. Refuse to enable the target if any of those validations fail. These validations are already done for the target passed on the command-line, so this aligns dynamic targets with the command-line behavior. The first two patches replace the per-target 'ipv6' flag with a per-address 'family' field, which makes it easier to detect these error conditions. Patches 3 and 4 implement the actual validations. Patches 5-7 are follow-ups from previous reviews: move inet_addr from netpoll.h into netconsole.c, show an unset address as an empty string rather than "0.0.0.0", document local_ip auto-selection. Signed-off-by: Gustavo Luiz Duarte <[email protected]> --- Changes in v3: - Document local_ip auto-selection - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Show empty string in configfs for an unset IP address - Moved inet_addr definition from netpoll.h to netconsole.c - Moved address checks out of rtnl_lock() - Link to v1: https://patch.msgid.link/[email protected] To: Breno Leitao <[email protected]> To: Andrew Lunn <[email protected]> To: "David S. Miller" <[email protected]> To: Eric Dumazet <[email protected]> To: Jakub Kicinski <[email protected]> To: Paolo Abeni <[email protected]> To: Simon Horman <[email protected]> To: Jonathan Corbet <[email protected]> To: Shuah Khan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] --- Gustavo Luiz Duarte (7): netconsole: add an address family to struct inet_addr netconsole: use the address family instead of the ipv6 flag netconsole: reject enabling a target with no remote IP address netconsole: reject a target mixing IPv4 and IPv6 addresses netconsole: show empty string for an unset IP address netconsole: move struct inet_addr into netconsole.c docs: netconsole: document local_ip auto-selection Documentation/networking/netconsole.rst | 5 ++ drivers/net/netconsole.c | 132 ++++++++++++++++---------------- include/linux/netpoll.h | 5 -- 3 files changed, 70 insertions(+), 72 deletions(-) --- base-commit: 4f93b12cf7b25fbf8e73d222722805b049f0a6d3 change-id: 20260730-netcons_ipv6-565d55f55729 Best regards, -- Gustavo Luiz Duarte <[email protected]>