Re: [PATCH v19 05/14] KVM: arm64: Set PSTATE.EXLOCK when entering an exception

On Thu, Aug 20, 2026 at 06:04:18PM +0100, Leonardo Bras wrote:
> On Wed, Aug 12, 2026 at 08:12:04PM +0100, Mark Brown wrote:

> > +	// PSTATE.EXLOCK is set to 0 upon any exception to a higher
> > +	// EL, or to GCSCR_ELx.EXLOCKEN for an exception to the same
> > +	// exception level.  See ARM DDI 0487 R_WTXBY.
> > +	new |= compute_exlock(vcpu, mode, target_mode);

> we have here, instead (naming is bad):

> 	if (is_exlock_set(vcpu,...))
> 		new |= PSR_EXLOCK_BIT;

> this way it looks more like above sets, such as this one a few lines 
> earlier:

> 	if (kvm_has_mte(kern_hyp_va(vcpu->kvm)))
> 		new |= PSR_TCO_BIT;

> How does that sound?

I have no strong feeelings on that TBH, I can see preferences either
way.

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqHPWYACgkQJNaLcl1U
h9AwsQf/S3inTcyT1hgfbbryNePusskL/mmJx87RtuQbYbRy7diJF/0tJ9xVra03
qEGdF968NEAo0tQ3c8ufBUdLaeeHZPdm+rnaDMLJPGGj1O9Bj1scUrvA2oxx7oLt
jzTSO+ZFh3u3518O/QyUApNibBHtJdazfSZfaBkOFUcwJZN3QBO6hhfNKSlCpD1/
OYNT2Y5yuhgdIgWgCDKwH5K+Cd1PtvLt4cFqT5T3slwMcPiAtU/eCZZv96Wgu+Qu
O8+7FmKmryrXBmmHBr36WzkzsOskNyZ6FOzvkFN3zokCEoHcZm8ZKJtE53pxIU9p
uTqNNqstrEWAcMGEmIdNGRkhZopBWg==
=Ma8R
-----END PGP SIGNATURE-----