Re: [PATCH v9 3/3] iio: dac: Add AD5529R DAC driver support
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Aug 21, 2026 at 02:45:03AM +0100, Jonathan Cameron wrote: > On Thu, 20 Aug 2026 09:08:23 +0200 > Janani Sunil <[email protected]> wrote: > > > Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter > > from Analog Devices. > > > > The device communicates over SPI and supports per-channel output range > > configuration. An optional external 4.096V reference can be used in > > place of the internal reference. > Sashiko calls out that dependency should be on CONFIG_SPI. > > I didn't check it's reasoning but I believe the conclusion is correct. > If that's all that comes up, I can tweak whilst applying. Interestingly we have the following statistics (might be a few cases missing): $ git grep -n 'depends on.*[[:space:]\(]SPI_MASTER' | wc -l 156 $ git grep -n 'depends on.*[[:space:]\(]SPI\([^_]*\)\?$' | wc -l 299 But reading the Kconfig I tend to agree that what we need is SPI_MASTER. SPI might be enabled for SPI_SLAVE only, would it mean we have a usable HW on such a configuration / platform? > Looks good to me, but I'll leave it on list for a little longer > as we aren't in a rush and others may well want to review. ... > > +config AD5529R > > + tristate "Analog Devices AD5529R High Voltage DAC driver" > > + depends on SPI_MASTER > > depends on SPI > > > + select REGMAP_SPI -- With Best Regards, Andy Shevchenko