Re: [PATCH 2/2] docs/zh_TW: link to Traditional Chinese applying-patches translation
葉宸佑 <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAKspUhJLcgj8kdZ-Gg2b-v47zNnfkHm=q1yvpFxr__5_Pa1DeQ@mail.gmail.com> |
Two small things here. 1. The two files use different link styles README.rst:89 uses a bare path, which automarkup turns into a link and which doc-guide/sphinx.rst recommends. howto.rst:149 uses :doc: with the full path as the display text, which is effectively doing automarkup's job by hand. Either is fine, but they should match. If you add the .. _tw_applying_patches: label I suggested on 1/2, howto.rst could use :ref: and look like the eight entries around it. 2. Unrelated whitespace changes Both files lose a trailing blank line, which the commit message does not mention. Best dropped, or split out if it is deliberate. Thanks. Chen-Yu