Re: [PATCH v7 5/6] tools/mm: make gup_bench a benchmark only tool

Mike Rapoport <[email protected]> Mon, 24 Aug 2026 10:59:05 +0300

Newsgroups	org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm
Message-ID	<178755834511.3606540.5889183666243190319.b4-review@b4>

On Thu, 13 Aug 2026 23:42:29 +0530, Sarthak Sharma <[email protected]> wrote:
> Remove the functional modes (GUP_BASIC_TEST, PIN_BASIC_TEST and
> DUMP_USER_PAGES_TEST) from gup_bench. Drop the kselftest dependency
> and use normal diagnostics and exit statuses.
> 
> When no arguments are supplied, run a single GUP_FAST_BENCHMARK
> with the existing default values. Let users select other
> configurations through command-line options. Report ioctl failures
> and handle errors without relying on assert().
> 
> [...]

Acked-by: Mike Rapoport (Microsoft) <[email protected]>

-- 
Sincerely yours,
Mike.