Re: [PATCH v3 05/14] iio: adc: Add AD7768 and AD7768-4 core support

Philipp Zabel <[email protected]> Mon, 24 Aug 2026 16:45:01 +0200

Newsgroups	org.kernel.vger.linux-doc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On So, 2026-08-16 at 20:10 +0100, Jonathan Cameron wrote:
> On Thu, 13 Aug 2026 15:56:58 +0200
> Janani Sunil <[email protected]> wrote:
[...]
> > +static int ad7768_reset(struct ad7768_state *st)
> > +{
> > +	struct reset_control *reset_ctrl;
> > +	unsigned long reset_low_us;
> > +	unsigned long mclk;
> > +	int ret;
> > +
> > +	reset_ctrl = devm_reset_control_get_optional_exclusive(regmap_get_device(st->regmap),
> 
> Probably use a local variable for struct device *dev = regmap_get_device(st->regmap);
> to reduce line length.

Or just pass dev into ad7768_reset() as an additional parameter.

regards
Philipp