Re: dm review needed, was: Re: [PATCH v3 2/3] blk-cgroup: store blkcg in bio instead of blkg
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.llvm,org.kernel.vger.cgroups,org.kernel.vger.linux-bcache,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-raid,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Sep 18, 2026 at 05:19:53PM +0800, yu kuai wrote: > So I think we don't need to restore the reference, BTW, there is another approach to > avoid such problem in blk-throttle I don't take for now: > > For bio entering blk-throttle, we can clear the new flag and blkg reference directly > after the bio is throttled and before this bio is issuing to disk, because bio will > not enter blk-throttle in the completion path. And since blk-throttle is the only rq_qos > policy that can be enabled for bio-based disk, then dm_bio_record() will never see a > bio with the new flag set. That sounds much better, thanks!