Re: [PATCH] EDAC/versalnet: release remoteproc reference in remove
Borislav Petkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260607222020.GBaiXupFdAIH8uX28K@fat_crate.local> |
On Wed, Jun 03, 2026 at 09:35:06PM +0800, Guangshuo Li wrote:
> mc_probe() gets a remoteproc reference with rproc_get_by_phandle() and
> stores it in priv->mcdi->r5_rproc after the remote processor has been
> booted.
>
> The probe error paths release that reference with rproc_put(), but the
> remove path only shuts the remote processor down. This leaks the
> remoteproc device and module references on every successful probe/remove
> cycle.
>
> Call rproc_put() in mc_remove() after rproc_shutdown().
>
> Fixes: d5fe2fec6c40d ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Guangshuo Li <[email protected]>
> ---
> drivers/edac/versalnet_edac.c | 1 +
> 1 file changed, 1 insertion(+)
https://lore.kernel.org/r/[email protected]
We're sorting it out currently.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette