Re: [PATCH v5 0/2] Incorporate DRAM address in EDAC messages
Yazen Ghannam <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jun 11, 2026 at 09:16:11AM -0700, Borislav Petkov wrote: > On Thu, Jun 11, 2026 at 10:11:38AM -0400, Yazen Ghannam wrote: > > The fake_inject fields are targets. > > Uff, true story, I got confused, sorry. > > /facepalm. > > > Just curious, why not leave it? Do you think the bots will keep bringing > > it up? > > Ok, someone tells you about a bug in the software. You do nothing? > > When do you fix it if you intend to do so? > IMO, consider the risk and the outcome. In this case, the conditions to hit the issue are rare. Real DRAM ECC occurs and logged through EDAC: rare EDAC_DEBUG config option enabled: almost never User is doing a fake_inject: practically 0% chance If the issue occurs, what is the outcome? The "other_detail" string gets messed up for one of the error logs. Of course, if no one is using fake_inject, then removing it closes this small risk. I guess that's the point, right? Thanks, Yazen