Re: [PATCH v2] EDAC/altera: use SDMMC compatibles to select A10/S10 IRQ layout
Rounak Das <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAPYTKoNq4894bH5r3bAXLNDogWw52sFg-GCP4H7EDY+L871XHQ@mail.gmail.com> |
Thank you for the review. I originally used the altr,socfpga-s10-sdmmc-ecc compatible because in altr_portb_setup() np is the SD/MMC ECC node (found via of_find_compatible_node(…, “altr,socfpga-sdmmc-ecc”)) so reusing that felt natural there. I later realised that shifting to altr,socfpga-s10-ecc-manager is better especially in scenarios where np could be any child node. In v3, the compatible is read on the manager node. To avoid repeated calls (as you have mentioned), I have decided to store it as a `bool is_s10` in `struct altr_arria10_edac`