Re: [PATCH v2] EDAC/altera: use SDMMC compatibles to select A10/S10 IRQ layout

Rounak Das <[email protected]>
Newsgroups org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel
Message-ID <CAPYTKoPcDeY4sGRfeu9N4TbDaRpxrwRiYqU9bcz5YFxfR=dWiQ@mail.gmail.com>
Hi Dinh,

Thanks for testing on the Stratix10 devkit.

This looks like it was tested against v2. The message is threaded
under the v2 patch containing the v2 diff, which uses
`altr,socfpga-s10-sdmmc-ecc` inside `altr_edac_a10_device_add()`. This
only matches the SD/MMC node, causing `sdramedac` and `ocram-ecc` to
fall into the else clause and call `irq_of_parse_and_map(np, 1)`.
Those nodes only have a single interrupt, so it does `rc = -ENODEV`
which matches the log (-19).

v3 was reworked specifically to fix this issue by using
`altr,socfpga-s10-ecc-manager` once at the probe, under
`altr_edac_a10_probe` and storing it as `edac->is_s10`.
v3 link: https://lore.kernel.org/lkml/[email protected]/

Could you re-test against v3 when you get a chance?

Thanks,
Rounak
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.